Fix id in listguestosmapping search by sureshanaparti · Pull Request #13082 · apache/cloudstack

sureshanaparti · 2026-04-29T10:42:27Z

Description

This PR fix the id passed in listguestosmapping search.

The tests test_CRUD_operations_guest_OS_mapping, test_guest_OS_mapping_check_with_hypervisor in 'test_guest_os.py' are failing with error "Problem with condition: id".

2026-04-28 15:29:45,344 WARN  [c.c.a.d.ParamGenericValidationWorker] (qtp253011924-20:[ctx-c76bda5d, ctx-7d5bf577, ctx-35332a51]) (logid:f1b8b89a) Received unknown parameters for command listGuestOsMapping. Unknown parameters : listall
2026-04-28 15:29:45,345 ERROR [c.c.a.ApiServer] (qtp253011924-20:[ctx-c76bda5d, ctx-7d5bf577, ctx-35332a51]) (logid:f1b8b89a) unhandled exception executing api command: [Ljava.lang.String;@372450db java.lang.RuntimeException: Problem with condition: id
        at com.cloud.utils.db.SearchBase$Condition.toSql(SearchBase.java:521)
        at com.cloud.utils.db.SearchCriteria.getWhereClause(SearchCriteria.java:267)
        at com.cloud.utils.db.SearchCriteria.getWhereClause(SearchCriteria.java:285)
        at com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:374)
        at com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:369)
        at com.cloud.utils.db.GenericDaoBase.searchAndCount(GenericDaoBase.java:1525)
        at com.cloud.utils.db.GenericDaoBase.searchAndCount(GenericDaoBase.java:1515)
        at jdk.internal.reflect.GeneratedMethodAccessor190.invoke(Unknown Source)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:569)
        at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
        at com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:175)
        at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
        at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
        at jdk.proxy3/jdk.proxy3.$Proxy288.searchAndCount(Unknown Source)
        at com.cloud.server.ManagementServerImpl.listGuestOSMappingByCriteria(ManagementServerImpl.java:3084)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:569)
        at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
        at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
        at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
        at jdk.proxy3/jdk.proxy3.$Proxy247.listGuestOSMappingByCriteria(Unknown Source)
        at org.apache.cloudstack.api.command.admin.guest.ListGuestOsMappingCmd.execute(ListGuestOsMappingCmd.java:95)
        at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:173)
        at com.cloud.api.ApiServer.queueCommand(ApiServer.java:875)
        at com.cloud.api.ApiServer.handleRequest(ApiServer.java:689)
        at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:417)
        at com.cloud.api.ApiServlet$1.run(ApiServlet.java:194)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sureshanaparti · 2026-04-29T10:48:00Z

@blueorangutan package

blueorangutan · 2026-04-29T10:50:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2026-04-29T11:01:07Z

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.68%. Comparing base (ffebe8e) to head (73b8dfc).
⚠️ Report is 2 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...in/java/com/cloud/server/ManagementServerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #13082   +/-   ##
=========================================
  Coverage     17.67%   17.68%           
- Complexity    15789    15790    +1     
=========================================
  Files          5922     5922           
  Lines        533094   533094           
  Branches      65210    65210           
=========================================
+ Hits          94246    94259   +13     
+ Misses       428208   428194   -14     
- Partials      10640    10641    +1

Flag	Coverage Δ
uitests	`3.69% <ø> (ø)`
unittests	`18.75% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2026-04-29T11:46:55Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17654

sureshanaparti · 2026-04-29T14:54:20Z

@blueorangutan test ol8 vmware-70u3

blueorangutan · 2026-04-29T14:56:04Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

DaanHoogland

makes sense and code looks good, but I have no idea about the old code’s validity.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

sureshanaparti · 2026-04-29T17:10:13Z

makes sense and code looks good, but I have no idea about the old code’s validity.

@DaanHoogland It's due to recent change here: #12802, only KVM tests were performed on the PR. These tests (test_CRUD_operations_guest_OS_mapping, test_guest_OS_mapping_check_with_hypervisor) will be executed for VMware, Xen hypervisors only.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sureshanaparti · 2026-05-01T12:44:09Z

@blueorangutan ol9 xcpng83

sureshanaparti · 2026-05-01T13:00:57Z

@blueorangutan ol9 xcpng83

sureshanaparti · 2026-05-01T13:27:00Z

@blueorangutan test ol8 vmware-70u3

blueorangutan · 2026-05-01T13:28:03Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

DaanHoogland · 2026-05-01T14:41:03Z

@blueorangutan ol9 xcpng83

blueorangutan · 2026-05-02T09:28:59Z

[SF] Trillian test result (tid-16001)
Environment: xcpng83 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 64618 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13082-t16001-xcpng83.zip
Smoke tests completed. 142 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	167.08	test_events_resource.py
ContextSuite context=TestClusterDRS>:setup	`Error`	0.00	test_cluster_drs.py
test_01_non_strict_host_anti_affinity	`Error`	153.17	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	68.12	test_nonstrict_affinity_group.py
test_02_list_snapshots_with_removed_data_store	`Error`	15.60	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	15.60	test_snapshots.py
test_01_vpn_usage	`Error`	1.07	test_usage.py
test_11_destroy_vm_and_volumes	`Error`	23.84	test_vm_life_cycle.py
test_01_migrate_vm_strict_tags_success	`Error`	59.76	test_vm_strict_host_tags.py

blueorangutan · 2026-05-03T06:57:37Z

[SF] Trillian test result (tid-15986)
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 311436 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13082-t15986-vmware-70u3.zip
Smoke tests completed. 138 look OK, 11 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpn_usage	`Error`	1.14	test_usage.py
test_01_deploy_vm_on_specific_host	`Error`	13.73	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	3603.70	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	4.54	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	1.41	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	4.41	test_vm_deployment_planner.py
test_04_migrate_detached_volume	`Error`	1838.98	test_vm_life_cycle.py
test_09_expunge_vm	`Failure`	426.77	test_vm_life_cycle.py
test_11_destroy_vm_and_volumes	`Error`	1829.70	test_vm_life_cycle.py
test_13_destroy_and_expunge_vm	`Error`	5525.32	test_vm_life_cycle.py
test_01_unmanage_vm_cycle	`Error`	1939.99	test_vm_lifecycle_unmanage_import.py
ContextSuite context=TestUnmanageVM>:teardown	`Error`	1940.15	test_vm_lifecycle_unmanage_import.py
test_01_migrate_vm_strict_tags_success	`Error`	0.67	test_vm_strict_host_tags.py
test_02_migrate_vm_strict_tags_failure	`Error`	0.56	test_vm_strict_host_tags.py
test_01_restore_vm_strict_tags_success	`Error`	0.53	test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure	`Error`	0.55	test_vm_strict_host_tags.py
test_01_scale_vm_strict_tags_success	`Error`	0.54	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	`Error`	0.93	test_vm_strict_host_tags.py
test_01_deploy_vm_on_specific_host_without_strict_tags	`Error`	0.58	test_vm_strict_host_tags.py
test_02_deploy_vm_on_any_host_without_strict_tags	`Error`	0.64	test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success	`Error`	0.60	test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success	`Error`	0.61	test_vm_strict_host_tags.py
test_05_deploy_vm_on_specific_host_with_strict_tags_failure	`Failure`	0.62	test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure	`Failure`	0.59	test_vm_strict_host_tags.py
test_11_attach_volume_with_unstarted_vm	`Error`	1929.04	test_volumes.py
test_13_migrate_volume_and_change_offering	`Error`	2411.94	test_volumes.py
ContextSuite context=TestVolumes>:teardown	`Error`	1822.77	test_volumes.py
test_01_verify_ipv6_vpc	`Error`	3609.07	test_vpc_ipv6.py
test_01_verify_ipv6_vpc	`Error`	3609.28	test_vpc_ipv6.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Error`	3707.38	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Error`	1827.14	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Error`	3627.45	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	3625.19	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	1815.48	test_vpc_redundant.py
test_01_VPC_nics_after_destroy	`Error`	3620.13	test_vpc_router_nics.py
test_02_VPC_default_routes	`Error`	3621.21	test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn	`Failure`	1665.49	test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn	`Error`	1665.63	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Error`	2523.66	test_vpc_vpn.py
test_01_vpc_remote_access_vpn	`Failure`	3607.26	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Error`	2072.57	test_vpc_vpn.py
test_01_cancel_host_maintenace_with_no_migration_jobs	`Error`	1808.14	test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	3691.30	test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	3691.54	test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure	`Error`	1803.75	test_host_maintenance.py

Fix id in listguestosmapping search

73b8dfc

boring-cyborg Bot added the component:management-server label Apr 29, 2026

sureshanaparti requested review from DaanHoogland and nvazquez April 29, 2026 10:42

sureshanaparti added this to the 4.22.1 milestone Apr 29, 2026

sureshanaparti added this to Apache CloudStack 4.22.1 Apr 29, 2026

github-project-automation Bot moved this to Todo in Apache CloudStack 4.22.1 Apr 29, 2026

sureshanaparti moved this from Todo to In Progress in Apache CloudStack 4.22.1 Apr 29, 2026

DaanHoogland requested a review from Copilot April 29, 2026 15:25

DaanHoogland reviewed Apr 29, 2026

View reviewed changes

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Copilot started reviewing on behalf of DaanHoogland April 29, 2026 16:03 View session

DaanHoogland requested a review from Copilot April 30, 2026 08:07

DaanHoogland approved these changes Apr 30, 2026

View reviewed changes

Copilot started reviewing on behalf of DaanHoogland April 30, 2026 08:08 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Conversation

sureshanaparti commented Apr 29, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented Apr 29, 2026

Uh oh!

blueorangutan commented Apr 29, 2026

Uh oh!

codecov Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Apr 29, 2026

Uh oh!

sureshanaparti commented Apr 29, 2026

Uh oh!

blueorangutan commented Apr 29, 2026

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Apr 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

sureshanaparti commented May 1, 2026

Uh oh!

sureshanaparti commented May 1, 2026

Uh oh!

sureshanaparti commented May 1, 2026

Uh oh!

blueorangutan commented May 1, 2026

Uh oh!

DaanHoogland commented May 1, 2026

Uh oh!

blueorangutan commented May 2, 2026

Uh oh!

blueorangutan commented May 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Apr 29, 2026 •

edited

Loading